-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TIER1 network debug page #8181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saketh-are
changed the title
Improve Network Info debug page
Add TIER1 network debug page
Dec 8, 2022
pompon0
reviewed
Dec 9, 2022
LG, I've just added one comment |
saketh-are
requested review from
mm-near and
pompon0
and removed request for
mm-near
December 9, 2022 14:00
pompon0
approved these changes
Dec 9, 2022
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Dec 14, 2022
Adds a separate page `/debug/pages/tier1_network_info` displaying information about TIER1 connections. For TIER1 connections we mostly display the same information as TIER2 connections, except that: - TIER1 messages don't include height, last block hash, or nonce info, so these columns are omitted - TIER1 nodes have configured public proxies; a column is added to display their addresses Includes a couple of minor tweaks to the TIER2 `network_info` page (show PeerId of the current node at the top of the page, rename the connection table's `AccountId` column to `PeerId`).
near-bulldozer bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
This endpoint was added mistakenly (by me) in #8181. It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality. Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
nikurt
pushed a commit
that referenced
this pull request
Aug 24, 2023
This endpoint was added mistakenly (by me) in #8181. It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality. Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Aug 24, 2023
This endpoint was added mistakenly (by me) in near#8181. It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality. Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
nikurt
pushed a commit
that referenced
this pull request
Aug 28, 2023
This endpoint was added mistakenly (by me) in #8181. It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality. Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a separate page
/debug/pages/tier1_network_info
displaying information about TIER1 connections. For TIER1 connections we mostly display the same information as TIER2 connections, except that:Includes a couple of minor tweaks to the TIER2
network_info
page (show PeerId of the current node at the top of the page, rename the connection table'sAccountId
column toPeerId
).