Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TIER1 network debug page #8181

Merged
merged 18 commits into from
Dec 9, 2022
Merged

Add TIER1 network debug page #8181

merged 18 commits into from
Dec 9, 2022

Conversation

saketh-are
Copy link
Collaborator

@saketh-are saketh-are commented Dec 7, 2022

Adds a separate page /debug/pages/tier1_network_info displaying information about TIER1 connections. For TIER1 connections we mostly display the same information as TIER2 connections, except that:

  • TIER1 messages don't include height, last block hash, or nonce info, so these columns are omitted
  • TIER1 nodes have configured public proxies; a column is added to display their addresses

Includes a couple of minor tweaks to the TIER2 network_info page (show PeerId of the current node at the top of the page, rename the connection table's AccountId column to PeerId).

@saketh-are saketh-are changed the title Improve Network Info debug page Add TIER1 network debug page Dec 8, 2022
@pompon0
Copy link
Contributor

pompon0 commented Dec 9, 2022

LG, I've just added one comment

@saketh-are saketh-are marked this pull request as ready for review December 9, 2022 14:00
@saketh-are saketh-are requested a review from a team as a code owner December 9, 2022 14:00
@saketh-are saketh-are requested review from mm-near and pompon0 and removed request for mm-near December 9, 2022 14:00
@near-bulldozer near-bulldozer bot merged commit 63d77d4 into near:master Dec 9, 2022
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Dec 14, 2022
Adds a separate page `/debug/pages/tier1_network_info` displaying information about TIER1 connections. For TIER1 connections we mostly display the same information as TIER2 connections, except that:
- TIER1 messages don't include height, last block hash, or nonce info, so these columns are omitted
- TIER1 nodes have configured public proxies; a column is added to display their addresses

Includes a couple of minor tweaks to the TIER2 `network_info` page (show PeerId of the current node at the top of the page, rename the connection table's `AccountId` column to `PeerId`).
near-bulldozer bot pushed a commit that referenced this pull request Aug 9, 2023
This endpoint was added mistakenly (by me) in #8181.

It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality.

Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
nikurt pushed a commit that referenced this pull request Aug 24, 2023
This endpoint was added mistakenly (by me) in #8181.

It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality.

Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Aug 24, 2023
This endpoint was added mistakenly (by me) in near#8181.

It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality.

Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
nikurt pushed a commit that referenced this pull request Aug 28, 2023
This endpoint was added mistakenly (by me) in #8181.

It returns a response completely identical to the one given by the `network_info` endpoint and adds no functionality.

Also, @telezhnaya pulled numbers from the last 6 months and `tier1_network_info` was used 0 times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants